feat: contribute aws eks resource detector #1479
Open
+507
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiyuan-he
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle,
xuan-cao-swi and
a team
as code owners
yiyuan-he
force-pushed
the
contribute-eks-resource-detector
branch
2 times, most recently
from
cba8900 to
ee6ba6f
Compare
yiyuan-he
changed the title
yiyuan-he
force-pushed
the
contribute-eks-resource-detector
branch
from
17b1826 to
8787fea
Compare
yiyuan-he
force-pushed
the
contribute-eks-resource-detector
branch
from
dc4076c to
eacac6a
Compare
kaylareopelle
approved these changes
May 15, 2025
There was a problem hiding this comment.
this looks great! thanks @yiyuan-he
one comment about the error handlers vs. logs
I was wrong about the error handlers! Failure to detect should not be an error log.
See #1538
| it 'returns an empty resource with unknown detector' do | ||
| assert_detection_result([:unknown]) | ||
| end | ||
|
|
||
| it 'returns an empty resource with multiple detectors when all fail' do | ||
| assert_detection_result(%i[ec2 ecs unknown]) | ||
| assert_detection_result(%i[ec2 ecs eks lambda unknown]) |
There was a problem hiding this comment.
Ah okay no worries. In that case, i'll keep this EKS detector as is since it's already using debug logs and update the other detectors. Left a comment in that issue as well.
EDIT: Meant to leave this reply in the other thread.
| request = case method.upcase | ||
| when 'GET' | ||
| Net::HTTP::Get.new(uri) | ||
| when 'POST' |
There was a problem hiding this comment.
am I missing something here. Is there a case where POST is used?
There was a problem hiding this comment.
Thanks for pointing this out Ariel - POST should not be used. Pushed a commit to clean up this dead code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Adds functionality for AWS EKS resource detection in AWS resource detector gem. It is similar to the implementation for Python.
This feature is branched off PR.
Related issues
#34